Patch 2 #2
Open
Patch 2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will users query run time of: a) only finished (success + failed) jobs b) only successful jobs c) all jobs etc
… 6 digits after the decimal point. This ensures there is no non-terminating decimal expansion when 10 ml of Whole Blood is divided into 3 parts.
OPSMN-5168: Added index on the parent_record_id and record_id columns of the sub-form and MV field tables. OPSMN-5195: Logged the generated SQLs by the query module at the debug level.
the forms use placeholders to display the field labels.
…ile exporting the audit logs.
…pecimens UI. This allows users to record the actual date/time of transferring specimens or retrieving specimens from the containers.
a) added an option to copy the distribution quantity of the first specimen to the others specimens of the order. b) allowed users to distribute the specimens without closing even when the distribution quantity >= available quantity.
1. Added ability to create bulk aliquots and link them to the anticipated requirements. 2. Query all descendent aliquots of a given specimen. Useful for displaying all aliquots in the mobile app aliquots tab. 3. Separated the data collection forms for primary specimens and aliquots. 4. Ability to retrieve specimen detail without retrieving any of its children. 5. Other minor fixes/improvements.
even when there are fatal errors like unreachable database etc. Added debug logs for checking the thread health.
up the DOM hierarchy. This ensured there was no browser form submit when the cancel button was clicked. Clicking on cancel button was triggering the browser form submit action, which in turn
Navigated the users back to the CP list when cancel is clicked in the CP import form.
passwords of the users affiliated to their institute.
…rofile dropdown menu.
…r) to remove the leading and trailing whitespaces from the string fields.
the CP level configuration is not done.
The problem - user context was not passed to the form data APIs when erasing the PHI field values. As a result, the form auditing failed with NPE when accessing the user information. Initialised the user context object and passed to form data APIs for use in auditing.
Import participants, specimens and aliquots into OpenSpecimen database.
download job reports etc. Refactored the importer to get rid of code duplication, save the job status etc.
… the mobile offline data.
…fields, if any, when there is no screen customisation JSON. The problem was, an incorrect variable name was referenced in the widget, which resulted in crashing of the UI thread just before the custom fields were rendered.
Added a plugin hook for bulk ops on the participant list page.
…r of their registration dates.
1) The bulk delete participant API runs in asynchronous mode. 2) The users are notified with an email containing the details of deleted participants as well as errors, if any, that were encountered during the delete ops. 3) Each participant is deleted in a separate transaction to avoid DB overhead.
…ctive DP and institute records when the input activity status is 'Disabled'. The fixes are useful for deleting multiple DPs and institutes using bulk import mechanism.
…encing deleted CP or CP groups.
one of the user types.
…pants based on MRN and UID/SSN as well.
…cimens in the list are always sorted based on their IDs irrespective of whether they are retrieved in the cart context or something else.
…sing or modifying CPs of other institutes. Users having read/write rights on all CPs of all sites were able to access CPs of other institutes as well.
--- OPSMN-5325: Removed the restriction of max 1000 literals in the IN clause. The restriction has been relaxed for MySQL. Removal of this restriction doesn't allow users to include any number of literals in the IN clause. The max will be dictated by the underlying database query parse buffer, efficiency of database to handle large values.
Broken the existing "Visit and Primary Specimens" and "Visit and Specimens" into 3 different resources - "Visits", "Primary Specimens", and "Specimens" This allows fine grained controlling of who can create and update visits without having to look into the specimens etc.
record in the import CSV file. Propagated the exceptions, if any, received during the flush operation to the higher layers for further handling and reporting.
…tween 2 dates in the requested units - years, months, and days. Earlier when the interval was 1y3m4d, the days interval API returned 4d instead 460d, months interval API returned 3m instead of 15m. This is incorrect.
However, the effect is visible only for the primary and derived specimens.
user broadcasting the announcement when no admin email ID is configured. The problem with using dummy email ID like localhost@localhost is that it is a valid email ID for MTA like postfix which tries to find a user 'localhost' on the VM, which may not be present. This causes the MTA to reject the email.
preparation of custom fields record when no collection protocol information is available. The problem is when no PPID is specified, the factory has no idea about the CP for which the visit is being created. However, in its attempt to report all errors, it tries to prepare the custom fields and crashes. Therefore the fix is to avoid custom fields preparation when no CP information is available. This will allow the factory to report the other accumulated errors.
…bare minimum mandatory fields like PPID, Visit Names, CP short title in the input CSV are filled before attempting to process the form fields.
These are similar to the events published during visit and specimen CRUD ops.
The challenge was to not load the default container types list twice - once for displaying the main list and other for the dropdown in the search view.
Fixed the form update APIs to prevent changing of field types except in the following cases: a) radio button to single-select dropdown and vice-versa b) checkbox to multi-select dropdown and vice-versa c) form data table is managed by the host application as in collection event, received events, query forms etc.
"More" menu in the CP based participants/specimens list view.
input login sessions. This query is used to populate the active time column of the login audit report.
Example configuration:
{
"defaultValue": "Support",
"leafValue": false,
"attribute": "ticket_type"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.