Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Address the case of no volumes to scrub when given the scrubbing strategy #156

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

htwangtw
Copy link
Collaborator

@htwangtw htwangtw commented Jun 3, 2024

A data set can have data where non steady volumes were not present and no volumes scrubbed.

This was detected from running on ds000228.

Bug introduced by #144

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (e44fca6) to head (6a71292).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   94.05%   94.03%   -0.03%     
==========================================
  Files          18       18              
  Lines         757      754       -3     
==========================================
- Hits          712      709       -3     
  Misses         45       45              
Files with missing lines Coverage Δ
giga_connectome/denoise.py 86.20% <100.00%> (-0.46%) ⬇️
giga_connectome/tests/test_denoise.py 100.00% <ø> (ø)

@htwangtw htwangtw merged commit f708610 into main Jun 3, 2024
18 checks passed
@htwangtw htwangtw deleted the fix/scrubbing-meta-data branch June 3, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant