-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add methods section #77
Conversation
The content should adapt depending on the arguments passed to the CLI. See example below. These results were generated with The following steps were followed.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 91.31% 91.63% +0.31%
==========================================
Files 9 10 +1
Lines 449 466 +17
==========================================
+ Hits 410 427 +17
Misses 39 39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth checking with COBIDAS and the bids BEP for connectivity to see what else can go in there.
What are the typical things you would expect to see in a methods section @htwangtw ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- post processing details done on fMRIPrep output
- Atlas used
- Connectome calculation methods (most common one is pearson's correlation with LedoitWolf covariance estimator)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the atlas I can only have the name with have in the json files.
If those have more details then we could inject it in the methods. Probably worth waiting with the BIDS effort to standardize atlases to make a move there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for waiting on BIDS effort.
What you have here is more than sufficient comparing to what I have seen in papers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you this is a nice addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for waiting on BIDS effort.
What you have here is more than sufficient comparing to what I have seen in papers
closes #63
This is meant as a first rough step.