-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix example misalignment #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Might avoid some confusion indeed.
I had made a figure (when this whole thing was on google doc) to help explain how I think that I had in mind the idea of putting in the BIDS specs but never got around to to it. I think @chrisfilo had made some comments on the figure being too "specific" and might lead people to assume that the content of I am happy to change it if there is interest in adding this to the specs. |
Indeed I cannot find in the standard a clear statement about the location of raw data. As a result colleagues of mine believe you may put raw data in a subfolder of the root folder such as I would also like to add a Perhaps we don't need to show the contents of the subfolder though. Should we show the contents of Finally what about adding bow-drawing characters to this example - like the
GitHub doesn't render it nicely but perhaps Read the Docs does. Perhaps a real figure like in #105 is preferable. |
Let's merge this as is since it clearly solves an existing problem (alignment). I totally agree that we need more clarification on where source vs raw data should go. @Remi-Gau I think your plots were very close and maybe we should bring them back. I also like the idea of listing @DimitriPapadopoulos consider also sending a PR adding yourself to https://github.com/bids-standard/bids-specification/blob/master/src/99-appendices/01-contributors.md and https://github.com/bids-standard/bids-specification/blob/master/CODEOWNERS |
Partially fixes #154. This fixes the example. However I believe a more “theoretical” discussion is required, explaining that raw data are stored directly under the dataset root folder, the same way source data are stored in subfolder
sourcedata
and derived data in subfolderderivatives
.