Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Add quality-of-life features to rendered spec #1618

Merged
merged 9 commits into from
Oct 4, 2023

Conversation

Remi-Gau
Copy link
Collaborator

Closes #1616

@Remi-Gau Remi-Gau added the exclude-from-changelog This item will not feature in the automatically generated changelog label Sep 25, 2023
@effigies
Copy link
Collaborator

Not a huge deal (and definitely doesn't need to be addressed here), but the DRAFT is much more prominent in dark mode:

image

If we could set that to switch with dark mode, then a version with inverted luminance would probably work well.

@Remi-Gau
Copy link
Collaborator Author

Not a huge deal (and definitely doesn't need to be addressed here), but the DRAFT is much more prominent in dark mode:

will check if some CSS magic can do the trick

@effigies
Copy link
Collaborator

Much better:

image

Thanks to @nellh and @rwblair for their knowledge of CSS that was updated more recently than 2009.

@Remi-Gau
Copy link
Collaborator Author

Thanks to @nellh and @rwblair

Well if the help of our web wizard and sorceress was required I did not stand a chance. 🤗

for their knowledge of CSS that was updated more recently than 2009.

hey at least you have some CSS knowledge... I just say I do.

Thanks y'all!

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f9cfafa) 87.83% compared to head (f5e18c0) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1618   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies changed the title [MAINT] add mkdocs enhancements [INFRA] Add quality-of-life features to rendered spec Oct 2, 2023
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice additions, thanks!

@Remi-Gau Remi-Gau merged commit 2d0c111 into bids-standard:master Oct 4, 2023
@Remi-Gau Remi-Gau deleted the enh_mkdocs branch October 4, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mkdocs enhancement suggestions
4 participants