Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP032: ephys -> {icephys, ecephys} #1806

Merged
merged 4 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/modality-specific-files/microelectrode-electrophysiology.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ You can also reach the moderators of this BEP through our [main discussion forum
Most core principles of the original BIDS and particulars of BIDS-iEEG specification are adopted
for this modality as well, though some special considerations and additional fields were added.

Several [example x datasets](https://bids-standard.github.io/bids-examples/#ephys)
Several [example x datasets](https://bids-standard.github.io/bids-examples/#microephys)
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
have been formatted using this specification and can be used for practical guidance when curating a new dataset.

## Primary data file formats

Unprocessed (animal) `ephys` data must be stored in an [open file format](https://en.wikipedia.org/wiki/Open_format),
Unprocessed microelectrode electrophysiology (`icephys` and `ecephys` modalities) data must be stored in an [open file format](https://en.wikipedia.org/wiki/Open_format),
while the native format, if different, can be stored in an optional `sourcedata/` directory.
The native file format is used in case conversion elicits the loss of crucial metadata specific to manufacturers and specific `ephys` systems.
The native file format is used in case conversion elicits the loss of crucial metadata specific to manufacturers and specific hardware systems.
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
Metadata should be included alongside the data in the `.json` and `.tsv` files.
The current list of allowed data file formats:

Expand All @@ -50,8 +50,8 @@ and a guide for using macros can be found at
-->
{{ MACROS___make_filename_template(
"raw",
datatypes=["ephys"],
suffixes=["ephys", "events"]
datatypes=["ecephys", "icephys"],
suffixes=["ecephys", "icephys", "events"]
)
}}

Expand Down
14 changes: 10 additions & 4 deletions src/schema/objects/datatypes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@ dwi:
display_name: Diffusion-Weighted Imaging
description: |
Diffusion-weighted imaging (DWI).
ecephys:
value: ecephys
display_name: Extracellular Electrophysiology
description: |
Electrophysiological data from an extracellular microelectrodes
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
eeg:
value: eeg
display_name: Electroencephalography
description: Electroencephalography
ephys:
value: ephys
display_name: Electrophysiology
description: Data acquired using microelectrodes.
fmap:
value: fmap
display_name: Field maps
Expand All @@ -34,6 +35,11 @@ func:
display_name: Task-Based Magnetic Resonance Imaging
description: |
Task (including resting state) imaging data
icephys:
value: icephys
display_name: Intracellular Electrophysiology
description: |
Electrophysiological data acquired from an individual cell
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
ieeg:
value: ieeg
display_name: Intracranial electroencephalography
Expand Down
4 changes: 2 additions & 2 deletions src/schema/objects/modalities.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ motion:
nirs:
display_name: Near-Infrared Spectroscopy
description: Data acquired with NIRS.
ephys:
microephys:
display_name: Microelectrode Electrophysiology
description: Data acquired using microelectrodes.
description: Electrophysiological data acquired using microelectodes.
17 changes: 11 additions & 6 deletions src/schema/objects/suffixes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,11 @@ dwi:
display_name: Diffusion-weighted image
description: |
Diffusion-weighted imaging contrast (specialized T2 weighting).
ecephys:
value: ecephys
display_name: Extracellular Electrophysiology
description: |
Extracellular electrophysiological data.
eeg:
value: eeg
display_name: Electroencephalography
Expand All @@ -583,11 +588,6 @@ electrodes:
display_name: Electrodes
description: |
File that gives the location of (i)EEG electrodes.
ephys:
value: ephys
display_name: Microelectrode Electrophysiology
description: |
Extra- or intracellular microelectrode recording data.
epi:
value: epi
display_name: EPI
Expand Down Expand Up @@ -617,6 +617,11 @@ hipCT:
display_name: HiP-CT
description: |
Hierarchical Phase-Contrast Tomography imaging data
icephys:
value: icephys
display_name: Inracellular Electrophysiology
description: |
Intracellular electrophysiological data.
ieeg:
value: ieeg
display_name: Intracranial Electroencephalography
Expand Down Expand Up @@ -758,7 +763,7 @@ probes:
value: probes
display_name: Implanted physical devices
description: |
Physical devices used for recording ephys data, whether chronically or acutely implanted.
Physical devices used for recording microelectrode electrophysiology data, whether chronically or acutely implanted.
probseg:
value: probseg
display_name: Probabilistic Segmentation
Expand Down
12 changes: 6 additions & 6 deletions src/schema/rules/files/raw/channels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ channels:
acquisition: optional
run: optional

# ephys has an additional 'sample' entity
channels__ephys:
# cephys has an additional 'sample' entity
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
channels__cephys:
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
$ref: rules.files.raw.channels.channels
datatypes:
- ephys
- cephys
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
entities:
$ref: rules.files.raw.channels.channels.entities
sample: optional
Expand Down Expand Up @@ -66,11 +66,11 @@ coordsystem__eeg:
$ref: rules.files.raw.channels.coordsystem.entities
space: optional

# ephys has sample AND space entities
coordsystem__ephys:
# cephys has sample AND space entities
coordsystem__cephys:
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
$ref: rules.files.raw.channels.coordsystem
datatypes:
- ephys
- cephys
yarikoptic marked this conversation as resolved.
Show resolved Hide resolved
entities:
$ref: rules.files.raw.channels.coordsystem.entities
sample: optional
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
---
ephys:
microephys:
suffixes:
- ephys
- ecephys
- icephys
extensions:
- .nwb
# possible future: serialization in .zarr format to accompany .ome.zarr
# - .nwb.zarr
- .nix
datatypes:
- ephys
- ecephys
- icephys
entities:
subject: required
session: optional
Expand All @@ -24,7 +26,8 @@ probes:
extensions:
- .tsv
datatypes:
- ephys
- ecephys
- icephys
entities:
subject: required
session: optional
Expand Down
Loading