-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Apply derivative definition to qMRI appendix #1813
Conversation
Remi-Gau
commented
May 6, 2024
•
edited
Loading
edited
- closes update qMRI to align with the new definition of derivatives #1812
- update qMRI sections that mention qmaps: https://bids-specification--1813.org.readthedocs.build/en/1813/appendices/qmri.html#outputs-are-quantitative-maps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 16 16
Lines 1396 1396
=======================================
Hits 1230 1230
Misses 166 166 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
Will create a companion PR to modify a couple of bids example to make that the validator has got something to sink its teeth into. |
@agahkarakuzu can you maybe cross-check what I did here? |
@Remi-Gau the changes you introduced looks good to me! This was initially what we wanted to do, but at that time it was not really clear. Thank you! |
Co-authored-by: Taylor Salo <[email protected]>