Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Fix dicomlookup links, link consistently #1988

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

effigies
Copy link
Collaborator

Should fix failing link checks. Then semi-automatically added links to all DICOM tags following the pattern DICOM Tag \d{4}, \d{4}. Adjusted newlines when necessary, but did not aim for beauty.

@effigies
Copy link
Collaborator Author

Remaining link failures appear to be temporary errors.

@effigies effigies changed the title chore(links): Fix dicomlookup links, link consistently [INFRA] Fix dicomlookup links, link consistently Dec 10, 2024
@effigies
Copy link
Collaborator Author

@Remi-Gau While you're in a link-fixing mood, would you have a quick glance over this one?

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@Remi-Gau
Copy link
Collaborator

I think no one will be outraged it this were merged with only 1 review

@effigies effigies merged commit 73ff325 into bids-standard:master Dec 12, 2024
24 of 25 checks passed
@effigies effigies deleted the fix/checklinks branch December 12, 2024 20:55
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants