Fix evm fee selection (#1608)

* fix 10% buffer computational logic * Correct gas fee parameter
bifrost-io · Jan 15, 2025 · b448607 · b448607
1 parent ad1ee93
commit b448607
Show file tree

Hide file tree

Showing 4 changed files with 65 additions and 11 deletions.
diff --git a/pallets/flexible-fee/src/impls/account_fee_currency.rs b/pallets/flexible-fee/src/impls/account_fee_currency.rs
@@ -62,7 +62,7 @@ impl<T: Config> AccountFeeCurrency<T::AccountId> for Pallet<T> {
 
 		// Add a 10% buffer to account for potential inaccuracies in fee estimation.
 		let fee = fee
-			.checked_mul(10)
+			.checked_mul(110)
 			.and_then(|v| v.checked_div(100))
 			.ok_or(Error::<T>::PercentageCalculationFailed)?;
 		for maybe_currency in currency_list.iter() {

diff --git a/pallets/flexible-fee/src/tests/common_tests.rs b/pallets/flexible-fee/src/tests/common_tests.rs
@@ -626,6 +626,52 @@ fn get_fee_currency_should_work_with_default_currency() {
 	});
 }
 
+#[test]
+fn get_fee_currency_should_work_with_dot() {
+	new_test_ext().execute_with(|| {
+		ini_meta_data();
+
+		let origin_signed_alice = RuntimeOrigin::signed(ALICE);
+		assert_ok!(FlexibleFee::set_user_default_fee_currency(
+			origin_signed_alice.clone(),
+			Some(DOT)
+		));
+
+		assert_ok!(Currencies::deposit(
+			DOT,
+			&ALICE,
+			660u128 * 10u128.pow(10) + 1
+		));
+		assert_ok!(Currencies::deposit(WETH, &ALICE, 100u128.pow(18)));
+
+		let currency = FlexibleFee::get_fee_currency(&ALICE, 10u128.pow(18).into()).unwrap();
+		assert_eq!(currency, DOT);
+	});
+}
+
+#[test]
+fn get_fee_currency_should_work_with_dot_weth() {
+	new_test_ext().execute_with(|| {
+		ini_meta_data();
+
+		let origin_signed_alice = RuntimeOrigin::signed(ALICE);
+		assert_ok!(FlexibleFee::set_user_default_fee_currency(
+			origin_signed_alice.clone(),
+			Some(DOT)
+		));
+
+		assert_ok!(Currencies::deposit(
+			DOT,
+			&ALICE,
+			660u128 * 10u128.pow(10) - 1
+		));
+		assert_ok!(Currencies::deposit(WETH, &ALICE, 100u128.pow(18)));
+
+		let currency = FlexibleFee::get_fee_currency(&ALICE, 10u128.pow(18).into()).unwrap();
+		assert_eq!(currency, WETH);
+	});
+}
+
 #[test]
 fn get_fee_currency_should_work_with_default_currency_poor() {
 	new_test_ext().execute_with(|| {

diff --git a/runtime/bifrost-paseo/src/evm/runner.rs b/runtime/bifrost-paseo/src/evm/runner.rs
@@ -28,6 +28,7 @@ use bifrost_primitives::{
 	AccountFeeCurrency, AccountFeeCurrencyBalanceInCurrency, Balance, CurrencyId,
 	OraclePriceProvider,
 };
+use core::ops::Mul;
 use fp_evm::{Account, TransactionValidationError};
 use frame_support::traits::{
 	tokens::{Fortitude, Preservation},
@@ -121,11 +122,14 @@ where
 		let account_id = T::AddressMapping::into_account_id(source);
 		let account_nonce = frame_system::Pallet::<T>::account_nonce(&account_id);
 
-		let (balance, b_weight) =
-			match B::get_balance_in_currency(evm_currency, &account_id, base_fee) {
-				Ok((balance, b_weight)) => (balance, b_weight),
-				Err(_) => (0, T::DbWeight::get().reads(2)),
-			};
+		let (balance, b_weight) = match B::get_balance_in_currency(
+			evm_currency,
+			&account_id,
+			base_fee.mul(U256::from(gas_limit)),
+		) {
+			Ok((balance, b_weight)) => (balance, b_weight),
+			Err(_) => (0, T::DbWeight::get().reads(2)),
+		};
 
 		let (source_account, inner_weight) = (
 			Account {

diff --git a/runtime/bifrost-polkadot/src/evm/runner.rs b/runtime/bifrost-polkadot/src/evm/runner.rs
@@ -28,6 +28,7 @@ use bifrost_primitives::{
 	AccountFeeCurrency, AccountFeeCurrencyBalanceInCurrency, Balance, CurrencyId,
 	OraclePriceProvider,
 };
+use core::ops::Mul;
 use fp_evm::{Account, TransactionValidationError};
 use frame_support::traits::{
 	tokens::{Fortitude, Preservation},
@@ -121,11 +122,14 @@ where
 		let account_id = T::AddressMapping::into_account_id(source);
 		let account_nonce = frame_system::Pallet::<T>::account_nonce(&account_id);
 
-		let (balance, b_weight) =
-			match B::get_balance_in_currency(evm_currency, &account_id, base_fee) {
-				Ok((balance, b_weight)) => (balance, b_weight),
-				Err(_) => (0, T::DbWeight::get().reads(2)),
-			};
+		let (balance, b_weight) = match B::get_balance_in_currency(
+			evm_currency,
+			&account_id,
+			base_fee.mul(U256::from(gas_limit)),
+		) {
+			Ok((balance, b_weight)) => (balance, b_weight),
+			Err(_) => (0, T::DbWeight::get().reads(2)),
+		};
 
 		let (source_account, inner_weight) = (
 			Account {