New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are these elements private? #141

Closed

fabianegli opened this issue Mar 17, 2023 · 1 comment · Fixed by #148

Collaborator

fabianegli commented Mar 17, 2023

It seems to me to defy the purpose to make these elements private.

sdrf-pipelines/sdrf_pipelines/openms/unimod.py

Lines 27 to 30 in babc93d

    
           self._ontology_term = ontology_term 
        
           self._delta_composition = delta_composition 
        
           self._site = sites 
        
           self._delta_mono_mass = delta_mono_mass

They seem to be intended for use. e.g. in https://github.com/nf-core/quantms/blob/0ca2cb5510d70cd8dddc125192dba7a50dca23a7/bin/prepare_diann_parameters.py#L49

Member

ypriverol commented Sep 4, 2023

Added the functions get for those properties. #148

ypriverol linked a pull request

that will close this issue

Conversion bruker data #148

Merged

3 tasks

ypriverol closed this as completed in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment