Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with ESLint Import Resolver #103

Merged
merged 7 commits into from
Jan 26, 2024

Conversation

ampersarnie
Copy link
Member

@ampersarnie ampersarnie commented Jan 10, 2024

Description

Fixes issues that have resulted in the implementation of the following changes when all brought into a single branch:

The change to the way ESLint config is used and implemented in the current release is not managed the same way in the proposed 1.3 release, meaning there has been a conflict in process for generating that ESLint config. TypeScript will need to set the project and accurate directory mappings for the TypeScript Resolver in the ESLint config to ensure the that the correct directories are being targeted. As a result of the changes, these mappings were incorrect in active use and in unit testing were partly non-existant.

Change Log

  • Adds missing scoped vars from test cases.
  • Changes project paths config to own file.
  • Changes ESLint Resolver config to create a fallback when a path config is not passed.
  • Adds config for ignore rules in Jest tests.

@ampersarnie ampersarnie changed the title Hotfix/eslint testing ts resolver Fix issues with ESLint Import Resolver Jan 11, 2024
@ampersarnie ampersarnie marked this pull request as ready for review January 11, 2024 11:37
@jaymcp jaymcp self-requested a review January 15, 2024 10:47
@ampersarnie ampersarnie merged commit cf27c20 into release/1.3 Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants