Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Node version 20 compatibility #122

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Conversation

PaulREnglish
Copy link
Contributor

@PaulREnglish PaulREnglish commented Jul 29, 2024

Issue Number

Issue: #108

Description

Addresses #108. Adds Node 20 compatibility to build tools including:

  • setting the default Node version to 20
  • fixes issues with npm dependencies and jest tests using Node 20.

Change Log

  • Sets default Node version to 20 in nvmrc
  • updates eslint-plugin-jsdoc package to 48.8.3
  • Removes mock-fs to fixes issue where jest tests were failing in Node 20 (see Fix compatibility with Node 20 tschaub/mock-fs#384)
    • Instead we use memfs and unionfs to mock the file system.

Notes

Previously, the jest tests used mock-fs to mock the file system.  However, there is compatibility issues between mock-fs and node 20.  See this issue: tschaub/mock-fs#384
@PaulREnglish PaulREnglish changed the title Update minimum Node version to v20 Adds Node version 20 compatibility Jul 29, 2024
@PaulREnglish PaulREnglish marked this pull request as ready for review July 30, 2024 08:47
@PaulREnglish PaulREnglish dismissed ampersarnie’s stale review August 13, 2024 15:34

The merge-base changed after approval.

ampersarnie
ampersarnie previously approved these changes Aug 13, 2024
Copy link
Member

@ampersarnie ampersarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you.

@ampersarnie ampersarnie self-requested a review August 13, 2024 15:43
ampersarnie
ampersarnie previously approved these changes Aug 13, 2024
@PaulREnglish PaulREnglish dismissed ampersarnie’s stale review August 13, 2024 15:43

The merge-base changed after approval.

@ampersarnie ampersarnie self-requested a review August 13, 2024 15:47
@ampersarnie ampersarnie merged commit 1efebfd into main Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants