Improve error handling in _pillow_heif.c
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncf
commented
Oct 10, 2024
A MemoryError is already set when PyObject_New fails: https://github.com/python/cpython/blob/2f8301cbf/Objects/object.c#L459-L468
johncf
force-pushed
the
error-handling
branch
from
bb675e7 to
f94bbbc
Compare
johncf
commented
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 956 956
=========================================
Hits 956 956 |
bigcat88
reviewed
Oct 13, 2024
bigcat88
reviewed
Oct 13, 2024
bigcat88
reviewed
Oct 13, 2024
bigcat88
approved these changes
Oct 13, 2024
Yes, this is ready to merge. Should I merge, or do you merge? |
|
thanks for this PR, ping me in another PR when it's ready =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on #297, I noticed that functions that don't return
NULLafter setting error doesn't raise exception. But when an exception is later thrown, it causes Python to raise aSystem Errorapparently because an exception was set earlier but was never thrown. This PR aims to fix some of these issues where returningNULLis more appropriate.Disclaimer: I am not an expert in Python C-API. I'm still learning (and have questions). So please review this carefully.