Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using encoderinfo for saving also for the non-primary images #313

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

bigcat88
Copy link
Owner

Fixes #308

I have no idea now why I originally wrote that this data was only transferred for the main image.

The change is small, in theory it shouldn't break anything, and in the future it will probably be necessary after a big refactoring (with Pillow 12?) to use encoderinfo for all these parameters, so the change is useful.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (4c24a2e) to head (c9b6a7c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files          10       10              
  Lines         976      975       -1     
==========================================
- Hits          975      974       -1     
  Misses          1        1              
Files with missing lines Coverage Δ
pillow_heif/as_plugin.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit 4ac4cf3 into master Nov 29, 2024
11 checks passed
@bigcat88 bigcat88 deleted the feat/encoderinfo-non-primary-images branch November 29, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lossless encoding for the non-primary image
1 participant