WIP fix(checkout): CHECKOUT-8264 Don't validate recaptcha if already validated #2697
+54
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchin
reviewed
Oct 16, 2024
| return this._executeRecaptcha(store); | ||
| } | ||
| } else { | ||
| return of(createAction(SpamProtectionActionType.ExecuteActionNotNeeded, undefined)); |
There was a problem hiding this comment.
Could we change the CustomerActionCreator to check the shouldExecuteSpamCheck flag instead, similar to how the check is implemented in PaymentStrategyActionCreator:
This approach will reduce the risk of change as it won't impact the payment step, which already has a check in place as shown above.
There was a problem hiding this comment.
Thanks DC. That seems good, that was my first thought as well 😄 Let me make that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Don't validate recaptcha if it's not needed or is already validated.
Why?
Testing / Proof
@bigcommerce/team-checkout @bigcommerce/team-payments