Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some runtime warnings #220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix some runtime warnings #220

wants to merge 2 commits into from

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Dec 24, 2024

What? Why?

A runtime warning was output when executing in the following environment, which has been corrected:

❯ ruby -v
ruby 3.4.0rc1 (2024-12-12 master 29caae9991) +PRISM [arm64-darwin23]
❯ RUBYOPT=-w bundle exec rake
/ydah/gruf/spec/support/helpers.rb:97: warning: possibly useless use of nil in void context
/ydah/gruf/spec/support/helpers.rb:88: warning: assigned but unused variable - e

How was it tested?

Verified that existing tests were not broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ydah