Cpp cleanup #67
Merged
Cpp cleanup #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence schema rather than only in-file.
tanaya-mankad
commented
Jan 16, 2025
| Description: "Base schema for ASHRAE 205 representations" | ||
| Version: "0.2.0" | ||
| References: | ||
| - "ASHRAE205" |
There was a problem hiding this comment.
Because the HeatSourceTemplate is in the ASHRAE205 schema, it becomes a dependency for the CPP generator (the derived classes need to know where to find & scope the base class from. I posted a question on Slack about this issue...
nealkruis
requested changes
Jan 17, 2025
lattice/file_io.py
Outdated
Comment on lines
59
to
62
| elif ext in [".h", ".cpp", ".txt"]: | ||
| with open(output_file_path, "w", encoding="utf-8") as src: | ||
| src.write(content) | ||
| src.write("\n") |
There was a problem hiding this comment.
This doesn't seem to fit here. content should be a dictionary.
nealkruis
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an omnibus:
Also, this branch includes work done on other unmerged branches, so they've come along for the ride (improved documentation, build support files.)