Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use proper type checking instead of helper function #120

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

sellth
Copy link
Collaborator

@sellth sellth commented Jan 15, 2024

No description provided.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2572456) 96.52% compared to head (2cba137) 96.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   96.52%   96.52%   -0.01%     
==========================================
  Files          29       29              
  Lines        3428     3427       -1     
==========================================
- Hits         3309     3308       -1     
  Misses        119      119              
Flag Coverage Δ
python 96.52% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe merged commit e10df5e into master Jan 18, 2024
7 checks passed
@holtgrewe holtgrewe deleted the fix_typing branch January 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants