Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inconsistent attribute naming #127

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: Inconsistent attribute naming #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions altamisa/isatab/parse_assay_study.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ def from_stream(cls, study_id: str, input_file: TextIO, filename: Optional[str]
def __init__(self, study_id: str, input_file: TextIO, filename: Optional[str]):
self.study_id = study_id
self.input_file = input_file
self.filename = filename or getattr(input_file, "name", "<no file>")
self._filename = filename or getattr(input_file, "name", "<no file>")
self.unique_rows = set()
self.duplicate_rows = []
self._reader = csv.reader(input_file, delimiter="\t", quotechar='"')
Expand Down Expand Up @@ -859,7 +859,7 @@ def read(self):

:returns: Nodes per row of the study file
"""
builder = _StudyRowBuilder(self.header, self.filename, self.study_id)
builder = _StudyRowBuilder(self.header, self._filename, self.study_id)
while True:
line = self._read_next_line()
if line:
Expand Down Expand Up @@ -942,7 +942,7 @@ def __init__(self, study_id: str, assay_id: str, input_file: TextIO, filename: O
self.study_id = study_id
self.assay_id = assay_id
self.input_file = input_file
self.filename = filename or getattr(input_file, "name", "<no file>")
self._filename = filename or getattr(input_file, "name", "<no file>")
self.unique_rows = set()
self.duplicate_rows = []
self._reader = csv.reader(input_file, delimiter="\t", quotechar='"')
Expand Down Expand Up @@ -984,7 +984,7 @@ def read(self):

:return: Nodes per row of the assay file
"""
builder = _AssayRowBuilder(self.header, self.filename, self.study_id, self.assay_id)
builder = _AssayRowBuilder(self.header, self._filename, self.study_id, self.assay_id)
while True:
line = self._read_next_line()
if line:
Expand Down