-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Move ISA-Tab templates into a separate repository (#96) #170
Conversation
Getting the following conflict locally: Once I attempt installing the expected depdndencies, the result is: pkg_resources.ContextualVersionConflict: (attrs 23.1.0 (/home/mikkopen/.virtualenvs/cubi-tk/lib/python3.8/site-packages), Requirement.parse('attrs<22.0,>=21.2.0'), {'varfish-cli'})
|
Please format your code with black: |
Tests run fine for me. Had similar issues until I realised that pytest was not called from my venv but from |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 75.59% 75.48% -0.11%
==========================================
Files 98 98
Lines 7806 7767 -39
==========================================
- Hits 5901 5863 -38
+ Misses 1905 1904 -1
☔ View full report in Codecov by Sentry. |
This is a pull request for #96.
The new separate template repo cubi-isa-templates can be found here.
This is still a draft, please comment or improve as you need fit. I haven't published the package on PyPI yet and I don't recommend merging this until there's a proper PyPI dependency.
I've been unable to test this locally because I run into some errors with
varfish-cli
dependencies (see below). Some cubi-tk expert might want to tell me what I'm doing wrong.