-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use iRODSCommon as parent class #208
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 79.84% 80.01% +0.16%
==========================================
Files 100 100
Lines 7701 7701
==========================================
+ Hits 6149 6162 +13
+ Misses 1552 1539 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far.
Do you want to merge this as is, or refactor all the other functions that could/should this this in one go?
Utilise common class introduced in #202 for
irods check
command.irods.check.IrodsCheckCommand
a child class ofiRODSCommon
snappy.pull_data_common
logic withiRODSTransfer
snappy.retrieve_irods_collection
to useiRODSCommon