Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use iRODSCommon as parent class #208

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

refactor: Use iRODSCommon as parent class #208

wants to merge 4 commits into from

Conversation

sellth
Copy link
Contributor

@sellth sellth commented Jan 4, 2024

Utilise common class introduced in #202 for irods check command.

  • make irods.check.IrodsCheckCommand a child class of iRODSCommon
  • refactor snappy.pull_data_common logic with iRODSTransfer
  • refactor snappy.retrieve_irods_collection to use iRODSCommon

@bihealth bihealth deleted a comment from github-actions bot Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67e6e49) 79.84% compared to head (5065c26) 80.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   79.84%   80.01%   +0.16%     
==========================================
  Files         100      100              
  Lines        7701     7701              
==========================================
+ Hits         6149     6162      +13     
+ Misses       1552     1539      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bihealth bihealth deleted a comment from github-actions bot Jan 4, 2024
@sellth sellth linked an issue Jan 4, 2024 that may be closed by this pull request
@sellth sellth marked this pull request as draft January 4, 2024 15:30
Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far.

Do you want to merge this as is, or refactor all the other functions that could/should this this in one go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor commonly use functionality, esp. from cubi-tk snappy
2 participants