Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new command sodar landing-zone-validate #219

Merged
merged 3 commits into from
Jan 25, 2024
Merged

feat: Add new command sodar landing-zone-validate #219

merged 3 commits into from
Jan 25, 2024

Conversation

sellth
Copy link
Contributor

@sellth sellth commented Jan 25, 2024

Augmentation of #206

closes #205

@sellth sellth mentioned this pull request Jan 25, 2024
Closed
Nicolai-vKuegelgen
Nicolai-vKuegelgen approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think for the future we should attempt to bundle all Sodar API functionality in some common class/module that can also be used for inheritance.
For now this works though.

@sellth sellth merged commit 98e21c1 into main Jan 25, 2024
4 checks passed
@sellth sellth deleted the 206-landing-zone-validate branch January 25, 2024 22:14
@your-highness
Copy link
Contributor

Just saw this! Thanks @sellth and @Nicolai-vKuegelgen to make this available. I could not find time to implement test procedures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicolai-vKuegelgen Nicolai-vKuegelgen Nicolai-vKuegelgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement planned feature sodar landing-zone-validate
3 participants
@sellth @your-highness @Nicolai-vKuegelgen