Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flat label list tab #194

Merged
merged 121 commits into from
Jan 30, 2025
Merged

Add flat label list tab #194

merged 121 commits into from
Jan 30, 2025

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Nov 12, 2024

  • Add tests in VideoAnnotationControllerTest
  • Add tests in ImageAnnotationControllerTest
  • Add project largo flat tab view
  • Update annotation count after swapping/deleting labels
  • Update label highlighting in LabelTab (and vice versa)

Closes #170.

@lehecht lehecht force-pushed the flat-label-list-tab branch from 74fc026 to db4486f Compare January 27, 2025 08:41
@lehecht lehecht requested a review from mzur January 27, 2025 09:22
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice improvement 👍 Two main comments:

  • The labels still are not ordered alphabetically. The volume endpoint sorts them correctly but the ordering is lost in the frontend. In the project endpoint the orderBy() is missing, too. You should add tests for this.

  • One thing I completely forgot about: Annotation sessions. If there is an annotation session that e.g. hides old annotations, these are still counted in the flat labels tab. When clicking on one of these labels, it says "no annotations exist". Adding the annotation session filter to the volume queries should be straight forward. Here is an example (also observe the edge case included there). Also add tests for this. Annotation sessions are ignored in project largo so there is no need to change anything there.

src/resources/assets/js/components/labelList.vue Outdated Show resolved Hide resolved
@lehecht lehecht force-pushed the flat-label-list-tab branch from 95c8b7e to 9accc1c Compare January 30, 2025 09:05
@lehecht lehecht force-pushed the flat-label-list-tab branch from 9accc1c to 918cec2 Compare January 30, 2025 09:07
@lehecht lehecht requested a review from mzur January 30, 2025 09:35
mzur
mzur previously approved these changes Jan 30, 2025
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks! Just one npm run prod was missing. I also updated the Largo manual article.

@mzur mzur merged commit 2bd4b87 into master Jan 30, 2025
2 checks passed
@mzur mzur deleted the flat-label-list-tab branch January 30, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flat label list tab
2 participants