ShipmentType in Shipment model is missing #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knaepel
changed the title
devtronic
requested changes
Mar 21, 2022
| * @var int | ||
| * @DataField(name="ShipmentType", type="int") | ||
| */ | ||
| public $shipmentType = 0; |
There was a problem hiding this comment.
Instead of using magic numbers it's better to use constants. Please create a src/Type/ShipmentType.php and add the constants SHIPMENT=0 and RETOURE=1. Use ShipmentType::SHIPMENT in this class.
(Similar to the definition of ProductCondition and its usage:
billbee-php-sdk/src/Model/Product.php
Line 416 in 07409bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I added the ShipmentType field to the Shipment Model.