This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mayuran/DPROD-2759/ws_improvements #7070
mayuran/DPROD-2759/ws_improvements #7070
Changes from 20 commits
fc54798
ca92e71
307c975
43e572c
60c1716
eacfe41
d62e8ff
102e343
664d1ca
59ab09f
be6dc8f
e33debc
be43c32
d10f917
ff92483
97078da
0f003c9
5b1e994
07f3451
51fa7f0
abb84c3
906f176
c8370ef
8a3bf6f
f4baf09
4fe3497
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kept console logs for QA purpose, later will remove console logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't
getLanguage()
return a default lang? Why?I think that instead of such checks you should be able to return a default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its old method which we are using to get language so i didn't change the method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can improve it. Why not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats where the high test coverage helps :) to increase confidence and thus enable refactors like that ;)
so developers are not worried of changing stuff as they know its gonna be caught by tests