Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: require python >= 3.10 #739

Merged
merged 4 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# *hgvs* - manipulate biological sequence variants according to Human Genome Variation Society recommendations

**Important:** biocommons packages require Python 3.8+.
[More](https://groups.google.com/forum/#!topic/hgvs-discuss/iLUzjzoD-28)
**Important:** biocommons packages require Python 3.10+.
[More](https://biocommons.org/en/latest/contributing/coding-guidelines/#other)

The *hgvs* package provides a Python library to parse, format, validate,
normalize, and map sequence variants according to [Variation
Expand Down
16 changes: 7 additions & 9 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ Highlights

* Test your code with ``make test`` before you submit a PR.

* Currently, only Python 2.7 is supported. Support for Python 3.5 is
slated for the next release
(`#190 <https://github.com/biocommons/hgvs/issues/190/>`__).
* Currently, only Python >=3.10 is supported, per `Biocommons policy <https://biocommons.org/en/latest/contributing/coding-guidelines/#other>`_.


A Quick Contribution Example
Expand Down Expand Up @@ -158,11 +156,11 @@ setting UTA_DB_URL. The format is
``postgresql://<user>:<pass>@<host>/<db>/<schema>``. For example:

``postgresql://anonymous:[email protected]/uta/uta_20140210``
explicitly selects the public database, and

explicitly selects the public database, and

``postgresql://localhost/uta/uta_20140210``

selects a local instance. Developers can test connectivity like this:

``$ UTA_DB_URL=postgresql://localhost/uta/uta_20140210 make test-quick``
Expand Down Expand Up @@ -232,13 +230,13 @@ understand the code.
variable names. |eg| ``var_c`` in a function argument list signifies
that a SequenceVariant object with type='c' is expected.

:hgvs*: a string representing an HGVS variant name.
:hgvs*: a string representing an HGVS variant name.

:var*: a :class:`hgvs.variant.SequenceVariant` object

:pos:
:pos:

:posedit:
:posedit:

:hgvs_position:

Expand Down
12 changes: 6 additions & 6 deletions docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Supported Platforms
to work on Mac. Other platforms and dependency versions are expected
to work but have not been tested. Reports of successful operation on
other platforms (and patches to enable this) are appreciated.
**Python >=3.5 is now required.**
**Python >=3.10 is now required.**



Expand All @@ -38,8 +38,8 @@ method for this is::
$ python3 -m venv venv
$ source venv/bin/activate

Your shell prompt will change upon activation.
Your shell prompt will change upon activation.

See `this tutorial
<https://realpython.com/python-virtual-environments-a-primer/>`__ for
more information about virtual environments.
Expand All @@ -59,7 +59,7 @@ Install hgvs via pip::
Installing hgvs from source (for developers)
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

For the project at https://github.com/biocommons/hgvs.
For the project at https://github.com/biocommons/hgvs.

Fetch the source code::

Expand Down Expand Up @@ -131,7 +131,7 @@ Test your installation
`hgvs` installs `hgvs-shell`, a command line tool based on
IPython. It's a convenience utility that imports and initializes
frequently-used components. Try this::

(default-2.7) snafu$ hgvs-shell
INFO:root:Starting hgvs-shell 1.0.0a1
INFO:biocommons.seqrepo:biocommons.seqrepo 0.3.1
Expand Down Expand Up @@ -170,4 +170,4 @@ in setup.py or requirements.txt indicates that version 1.0 (any patch
level) is required, and that future 1.x-series releases are
acceptable.


6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ authors = [
description = "HGVS Parser, Formatter, Mapper, Validator"
readme = "README.rst"
license = { file="LICENSE.txt" }
requires-python = ">=3.6"
requires-python = ">=3.10"
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
Expand All @@ -15,8 +15,8 @@ classifiers = [
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3",
"Programming Language :: Python",
"Topic :: Scientific/Engineering :: Bio-Informatics",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py38,py39,py310
envlist = py310,py311,py312

[testenv]
setenv =
Expand Down
Loading