Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phame #30939

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update phame #30939

wants to merge 4 commits into from

Conversation

brettyout
Copy link

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@BiocondaBot
Copy link
Collaborator

No artifacts found on the most recent CircleCI build. Either the build failed or the recipe was blacklisted/skipped.

@marcelm
Copy link
Contributor

marcelm commented Oct 23, 2021

Any idea why the homepage is the repo at https://github.com/LANL-Bioinformatics/PhaME, but the archive is downloaded from one of its forks, https://github.com/mshakya/PhaME?

@marcelm
Copy link
Contributor

marcelm commented Oct 23, 2021

@mshakya This is running into LANL-Bioinformatics/PhaME#11, do you have an idea what could be done?

20:07:30 BIOCONDA INFO (OUT) + phame --vcheck
20:07:30 BIOCONDA INFO (OUT) [20:07:30] Need samtools --version >= 1.3 but you have 1.13 - please upgrade it.

@mshakya
Copy link
Contributor

mshakya commented Oct 25, 2021

I think i know. This is the issue with parsing the two digit decimal points in version numbers. Will fix and try again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants