-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch srst2 versions 0.1.6 and 0.2.0 #6957
Conversation
Takadonet
commented
Nov 29, 2017
•
edited
Loading
edited
- I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- This PR updates an existing recipe.
- This PR does something else (explain below).
Do the changes from the patch alter the program's behavior for use cases which are not affected by katholt/srst2#99? If they do alter the program's default behavior, I don't think we should add those changes here but rather wait for an upstream update. As for the failed tests: Those are due to a current limitation in the testing framework concerning the use of single quotes in the test commands. If you replace the single quotes with double quotes, it should work fine. |
Fixed failed tests for version 0.1.4.6 . They don't alter the end results but just address the issue where file path cannot have '.' character. I am for sure willing to remove them from this branch for the latest version of the tool. It will limit our ability to update our wrapper since we don't have control on when the author will accept and publish a new release. |
@mbargull Removed patch and hope for srst2 to be updated with bug fix. |
Do you want to reinstate the patch for the current version or should we merge without it? After having a closer look at the patch, I think it is a justifiable addition/fix. |
I will reinstate the patch tomorrow. Working from home with a sick kid at the moment. |
No worries, I pushed the necessary changes. Everyone get well soon! |
@mbargull yes that is a typo. I believe I introduced it when we were updating our srst2 galaxy tool to use conda and I used the version we had in there which was a typo. |
@mbargull I guess I should clarify the typo is the 0.1.4.6 which should have been 0.1.6 |
Thanks for clarification, @ericenns. I just added a commit to this PR to fix this. |