Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended benchmarking cases #225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jwagner02
Copy link

  1. added additional benchmarking cases related to OTAR business questions
  • added benchmarking cases for SQL in addition to existing Cypher benchmarks
  1. added two additional KG schemas:
  • 'hetionet' based on hetionet drug repurposing KG
  • 'open-targets' based on open-targets KG

Copy link
Contributor

@slobentanzer slobentanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwagner02! Do you have any results; how do we see them and add them to the public benchmark?

@@ -3,7 +3,7 @@
#
# Test case keys:
# - input (for creating the test)
# - expected (for asserting outcomes and generating a score)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reintroduces typo that was fixed?

@@ -3,7 +3,7 @@
#
# Test case keys:
# - input (for creating the test)
# - expected (for asserting outcomes and generating a score)
# - expected (for asserting ourcomes and generating a score)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, typo here.

@@ -3,7 +3,7 @@
#
# Test case keys:
# - input (for creating the test)
# - expected (for asserting outcomes and generating a score)
# - expected (for asserting ourcomes and generating a score)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants