feat: Additional interval joins implementations #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiewior
commented
Aug 22, 2022
| var buffer_l_list: mutable.HashMap[ (Int, Int), LListElem[V]] = mutable.HashMap[ (Int, Int), LListElem[V]]() | ||
| var l_list: Array[LListElem[V]] = Array() | ||
| var h_list: ArrayBuffer[HListElem] = ArrayBuffer() | ||
| //var l_list_storage: ArrayBuffer[LListElem[V]] = ArrayBuffer[LListElem[V]]() |
|
|
||
|
|
||
| override def postConstruct(domains: Option[Int]):Unit = { | ||
| //if (!built) { |
There was a problem hiding this comment.
Remove commented out blocks.
| @@ -87,8 +87,11 @@ object IntervalTreeJoinOptimChromosomeImpl extends Serializable { | |||
| } | |||
| .collect() | |||
|
|
|||
| val domainsStringParam : String = spark.sqlContext.getConf(InternalParams.domains, | |||
| null ) | |||
| val intervalTree = { | ||
| val tree = new IntervalHolderChromosome[InternalRow](localIntervals, intervalHolderClassName) | ||
| val tree = if (domainsStringParam != null) new IntervalHolderChromosome[InternalRow](localIntervals, intervalHolderClassName, Option.apply(domainsStringParam.toInt)) else new IntervalHolderChromosome[InternalRow](localIntervals, intervalHolderClassName) |
There was a problem hiding this comment.
Better use Scala pattern matching mechanism with None
| @@ -3,7 +3,7 @@ package org.biodatageeks.sequila.rangejoins.methods.IntervalTree | |||
| import org.biodatageeks.sequila.rangejoins.IntervalTree.Interval | |||
| import org.biodatageeks.sequila.rangejoins.methods.base.BaseIntervalHolder | |||
|
|
|||
| class IntervalHolderChromosome[T](allRegions: Array[(String,Interval[Int],T)], intervalHolderClassName:String) extends Serializable { | |||
| class IntervalHolderChromosome[T](allRegions: Array[(String,Interval[Int],T)], intervalHolderClassName:String, domains: Option[Int] = None) extends Serializable { | |||
There was a problem hiding this comment.
I would suggest passing a generic Conf-type object which is a key/value instead of passing it explicitly.
| @@ -54,7 +54,6 @@ object InternalParams { | |||
| final val maxGap = "spark.biodatageeks.rangejoin.maxGap" | |||
| final val minOverlap = "spark.biodatageeks.rangejoin.minOverlap" | |||
| final val intervalHolderClass = "spark.biodatageeks.rangejoin.intervalHolderClass" | |||
|
|
|||
|
|
|||
| final val domains = "spark.biodatageeks.rangejoin.domains" | |||
There was a problem hiding this comment.
Rather name it as spark.biodatageeks.rangejoin.iitii.domainsNum
There was a problem hiding this comment.
Add documentation to : https://biodatageeks.github.io/sequila/docs/configuration/join/
There was a problem hiding this comment.
As well section on available algos in a tabular form:
https://biodatageeks.github.io/sequila/docs/algorithms/join/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.