Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #8 (comment).
This pull request adds a test with the file uploaded in Arcadia-Science/readlif#52 (comment).
As a workaround for the issue in
readlif
, we explicitly setchannel_as_second_dim
toFalse
when reading directly withreadlif
in the test. (The fixed version of readlif should set this toFalse
in any case.)With
readlif-0.6.4
, 3 out of 6 tests oftest_sanity_check_correct_indexing
fail:ZYX-ZYX-20250130_4Channels_5planes.lif
ZYX-TYX-20250130_4Channels_5planes.lif
ZYX-CYX-20250130_4Channels_5planes.lif
With the latest
readlif
from Arcadia-Science/readlif@586f24b, all 6 parameterized tests for this file pass.I can't test with the existing
bioio
test files, so I'm just submitting this as a draft PR.