Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with 4-channel lif file #18

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

imagejan
Copy link

Please see #8 (comment).

This pull request adds a test with the file uploaded in Arcadia-Science/readlif#52 (comment).

As a workaround for the issue in readlif, we explicitly set channel_as_second_dim to False when reading directly with readlif in the test. (The fixed version of readlif should set this to False in any case.)

With readlif-0.6.4, 3 out of 6 tests of test_sanity_check_correct_indexing fail:

  • ZYX-ZYX-20250130_4Channels_5planes.lif
  • ZYX-TYX-20250130_4Channels_5planes.lif
  • ZYX-CYX-20250130_4Channels_5planes.lif

With the latest readlif from Arcadia-Science/readlif@586f24b, all 6 parameterized tests for this file pass.

I can't test with the existing bioio test files, so I'm just submitting this as a draft PR.

@@ -32,8 +32,7 @@ dependencies = [
"fsspec>=2022.8.0",
"numpy>=1.16",
"PyYAML>=6.0",
"readlif>=0.6.4",
"xarray>=0.16.1",
"xarray>=0.16.1", "readlif @ https://github.com/Arcadia-Science/readlif.git",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting is a bit funky

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had used pixi CLI to add the dependency, and that's what it produced.

I would anyways update this draft PR and review the formatting once a new version of readlif is released, and depending on feedback here how to handle the (proposed) new test file.

@evamaxfield
Copy link

evamaxfield commented Feb 28, 2025

Just as a note: we should only be using this PR for testing and debugging purposes to see if the upstream changes will work with BioIO as is. Last time I tried to release a Python package using the pkg-name @ git+... as a dependency (which was yesterday), PyPI explicitly rejects that specification as a dependency and doesn't allow you to release a new version of the package.

This PR is greatly appreciated but sadly we likely shouldn't merge until the upstream releases a new version ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants