This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Fix workflow download/blog links #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two pages probably started as copies, one was being maintained, the other was not. Fixed the copy blunder.
markotoplak
force-pushed
the
fix-workflows
branch
from
8814b3b to
7c76e00
Compare
Someone seemingly autoformatted this with a tool that does not know Hugo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joined workflow and workflow/tags page.These were two pages that probably started as copies, one was being maintained, the other was not.
Before we had 4! different ways to produce a workflow description. 2 separate pages, and each of them made descriptions as a (1) hugo template or (2) dynamically in javascript (for search). Only 1/4 was working properly.
This fixes the copy blunder and #206 with it. Now we only have 2 different ways to show workflows. I fixed javascript codepath to return correct download and blog link. This fixed another bug: downloads were dead links also in search results).
While enjoying this code I identified 3 further issues for someone else to partake in joyful debugging: #207, #208, #209. Have fun!