Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic config file for documentation #271

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

ajdapretnar
Copy link
Collaborator

Issue

Config still not working.

Description of changes

Fixes basic config file, take 2.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cdca90) 77.92% compared to head (7813e51) 77.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files          28       28           
  Lines        4512     4512           
  Branches      612      612           
=======================================
  Hits         3516     3516           
  Misses        861      861           
  Partials      135      135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrimozGodec PrimozGodec reopened this Dec 22, 2023
@PrimozGodec
Copy link
Collaborator

I closed and opened the PR since I added RTD status to processes so that we can see if it fails.
And it seems the configuration layout changed a bit so most of our addons failed the build, and we didn't even notice since we don't have the status in checks.

@PrimozGodec PrimozGodec merged commit 033f5a2 into biolab:master Dec 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants