Support for querying for direct vs inferred associations, other fixes for ui #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some small updates to support querying direct vs inferred associations by querying the subject/object_eq closures that have been newly added to the monarch solr. This allows us to support direct queries on non clique leader identifiers, whereas before you were forced to use the subclass of|equivalence closure
Also some updates to support direct vs inferred taxa, although I may walk this back since including inferred taxa is desirable in the majority of cases, and we're only adding this because of some monarch hackiness - monarch-initiative/dipper#860
Support for a generic fq param in biolink is possibly more ideal for these scenarios, but curious others thoughts on this.