Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(noUselessEscapeInRegex): add rule #3604

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Aug 6, 2024

Summary

Implement partially #1090

Test Plan

I added all the tests of the ESLint rules.
We have a single divergence: we report \k as useless in non unicode-aware regexes.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Aug 6, 2024
@Conaclos Conaclos requested review from a team August 6, 2024 20:20
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48473 48473 0
Passed 47276 47276 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.53% 97.53% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6551 6551 0
Passed 2199 2199 0
Failed 4352 4352 0
Panics 0 0 0
Coverage 33.57% 33.57% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18334 18334 0
Passed 14027 14027 0
Failed 4307 4307 0
Panics 0 0 0
Coverage 76.51% 76.51% 0.00%

Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #3604 will improve performances by 6.75%

Comparing conaclos/noUselessEscapeInRegex (9a56c36) with main (2f8a37f)

Summary

⚡ 1 improvements
✅ 103 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/noUselessEscapeInRegex Change
react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +6.75%

@Conaclos Conaclos force-pushed the conaclos/noUselessEscapeInRegex branch from 7140c43 to ee63ffc Compare August 6, 2024 21:35
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, good diagnostics too! Just some nits on the wording.

@Conaclos Conaclos force-pushed the conaclos/noUselessEscapeInRegex branch 4 times, most recently from 7343ee9 to 94a4af7 Compare August 7, 2024 09:48
@Conaclos Conaclos force-pushed the conaclos/noUselessEscapeInRegex branch from 94a4af7 to 9a56c36 Compare August 7, 2024 10:00
Co-authored-by: Arend van Beelen jr. <[email protected]>
@Conaclos Conaclos merged commit f1ceeef into main Aug 7, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/noUselessEscapeInRegex branch August 7, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants