fix(grit): fix matching function body #3810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had an issue with matching function bodies in Grit queries that prevented metavariables from matching statements inside a function body. In fact, even the presence of a metavariable inside a snippet's function body would prevent the query from matching at all.
To fix it, I made sure
JsMetavariable
will be accepted in our grammar insideAnyJsStatement
and updated the JS parser so it's accepted there.Test Plan
Expanded test cases.