Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): make noRestrictedTypes common options simpler #3819

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented Sep 7, 2024

Summary

Allows passing string instead of full object noRestrictedTypes, make common configuration easier.

{
  "types": {
     "OldAPI": {
       "message": "Use NewAPI instead"
     }
  }
}

->

{
  "types": {
     "OldAPI": "Use NewAPI instead"
  }
}

No changelog entry since rule is not released yet.

Test Plan

Existing snapshots should pass.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 7, 2024
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #3819 will degrade performances by 48.16%

Comparing minht11:feat/simpler-no-restricted-types-option (48b752d) with main (7f02581)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main minht11:feat/simpler-no-restricted-types-option Change
big5-added_15586211152145260264.json[uncached] 542.3 µs 1,046.1 µs -48.16%

@minht11 minht11 merged commit d658225 into biomejs:main Sep 10, 2024
11 checks passed
@minht11 minht11 deleted the feat/simpler-no-restricted-types-option branch September 10, 2024 10:21
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants