refactor(css_semantic): improve CSS semantic model structure and API #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
togami2864
commented
Jan 18, 2025
Comment on lines
+33
to
+45
| // #[cfg(test)] | ||
| // mod tests { | ||
| // use biome_css_parser::parse_css; | ||
| // use biome_css_parser::CssParserOptions; | ||
| // use biome_rowan::TextRange; | ||
|
|
||
| // #[test] | ||
| // fn test_simple_ruleset() { | ||
| // let parse = parse_css( | ||
| // r#"p { | ||
| // font-family: verdana; | ||
| // font-size: 20px; | ||
| // }"#, |
There was a problem hiding this comment.
Temporarily disable the tests. I will make another PR to split them into another module.
togami2864
changed the title
togami2864
changed the title
CodSpeed Performance ReportMerging #4908 will improve performances by 11.35%Comparing Summary
Benchmarks breakdown
|
chansuke
reviewed
Jan 18, 2025
| }, | ||
| range: node.text_range(), | ||
| value: CssValue { node: value }, |
There was a problem hiding this comment.
imho: can be change to property_value as it aligns well with property_name?
Suggested change
| value: CssValue { node: value }, | |
| value: CssValue { node: property_value }, |
ematipico
reviewed
Jan 21, 2025
crates/biome_css_analyze/src/lint/nursery/no_duplicate_custom_properties.rs
Outdated
Show resolved
Hide resolved
Comment on lines
271
to
273
| pub fn text(&self) -> String { | ||
| self.node.text_trimmed().to_string() | ||
| } |
There was a problem hiding this comment.
No allocations. If the caller needs a String, they can do it. We should return a SyntaxText from here
This reverts commit 054316a.
|
I pushed some changes in this PR here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CssSyntaxNodeinstead of a String so that the model has more flexibility and extensibilityTest Plan
CI should pass