Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade rust v1.84.0 #4912

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

build: upgrade rust v1.84.0 #4912

wants to merge 5 commits into from
+226 −198

Conversation

unvalley
Copy link
Member

@unvalley unvalley commented Jan 19, 2025 •
edited
Loading

Summary

This PR upgrades rust (v1.84.0), fixes clippy errors and format.
Since I'd like to do the clippy fixes in the next branch, the direction was set as the next branch.

Reduced number of lint rules to apply compared to #4910 , they are should be warn after this pr merging

  • unnecessary_map_or = "allow"
  • needless_lifetimes = "allow"

Test Plan

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages L-HTML Language: HTML L-Grit Language: GritQL labels Jan 19, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4912 will not alter performance

Comparing unvalley:upgrade-rust-1.84.0 (95a06db) with next (4f07cc8)

Summary

✅ 95 untouched benchmarks

@unvalley unvalley marked this pull request as ready for review January 19, 2025 17:19
arendjr
arendjr approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-Grit Language: GritQL L-HTML Language: HTML L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unvalley @arendjr