Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xtask): check rustfmt version in codegen #5259

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

siketyan
Copy link
Member

@siketyan siketyan commented Mar 3, 2025

Summary

Closes #5258

I added checking the rustfmt version before running. Plus, I added a OnceLock to run rustfmt --version only once.

Test Plan

The codegen CI should pass.

@siketyan siketyan requested review from a team March 3, 2025 12:33
@siketyan siketyan self-assigned this Mar 3, 2025
@siketyan siketyan marked this pull request as ready for review March 3, 2025 12:33
@github-actions github-actions bot added the A-Tooling Area: internal tools label Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50388 50388 0
Passed 49073 49073 0
Failed 1315 1315 0
Panics 0 0 0
Coverage 97.39% 97.39% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6641 6641 0
Passed 2229 2229 0
Failed 4412 4412 0
Panics 0 0 0
Coverage 33.56% 33.56% 0.00%

ts/babel

Test result main count This PR count Difference
Total 798 798 0
Passed 706 706 0
Failed 92 92 0
Panics 0 0 0
Coverage 88.47% 88.47% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18658 18658 0
Passed 14309 14309 0
Failed 4349 4349 0
Panics 0 0 0
Coverage 76.69% 76.69% 0.00%

@siketyan siketyan merged commit af4c84b into main Mar 3, 2025
11 checks passed
@siketyan siketyan deleted the feat/check-rustfmt-version branch March 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Code generation failed when executing just new-js-lintrule
2 participants