refactor(playground): upgrade playground to be compatible with biome 2.0 #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dyc3
force-pushed
the
playground-next
branch
2 times, most recently
from
fcd98dd to
2c38520
Compare
dyc3
commented
Feb 5, 2025
Comment on lines
+274
to
+280
| const importSorting = { | ||
| code: "Moved to Analyzer Fixes tab", | ||
| }; |
There was a problem hiding this comment.
This is intentional since this PR is focused primarily on simply retaining existing functionality. Planning to fix in a follow up PR.
|
Arend created a |
|
FYI, I attempted to merge |
dyc3
force-pushed
the
playground-next
branch
from
684967d to
017d991
Compare
dyc3
force-pushed
the
playground-next
branch
2 times, most recently
from
bed605f to
06a2851
Compare
|
The integration tests are expected to fail here until this repo synchronizes with the main repo, since it depends on the new api surface. |
ematipico
approved these changes
Feb 12, 2025
|
Ah yeah I forgot about that. I'll go ahead and update this PR with a workaround and update #1727 with the UI changes. |
dyc3
force-pushed
the
playground-next
branch
from
06a2851 to
99ac052
Compare
ematipico
approved these changes
Feb 12, 2025
dyc3
force-pushed
the
playground-next
branch
from
99ac052 to
85eccec
Compare
dyc3
force-pushed
the
playground-next
branch
2 times, most recently
from
e4f3f24 to
82a99d2
Compare
dyc3
force-pushed
the
playground-next
branch
from
82a99d2 to
799debf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the playground so that it's compatible with the changes currently on
nextin the main Biome repo. It needs to be merged after biomejs/biome#4760. The goal for this PR is to simply make the playground functional for 2.0, not to add new features to support new 2.0 functionality.To test this, I've been using the following command to build the wasm bin and copy over to this repo's
node_modules: