Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test with minimum, median, and latest Perl versions #378

Merged
merged 1 commit into from
May 10, 2023
Merged

CI: test with minimum, median, and latest Perl versions #378

merged 1 commit into from
May 10, 2023

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Apr 27, 2023 •
edited
Loading

This is per discussion at:

Uses minimum (set at 5.12), median, and latest versions.

Currently 5.12 is broken with the error:

Error: Can't locate object method "new" via package "Bio::Search::HSP::GenericHSP::SUPER" at /home/runner/work/bioperl-live/bioperl-live/blib/lib/Bio/Search/HSP/GenericHSP.pm line 182, <GEN1> line 2564.
# Looks like your test exited with 255 just after 7.
t/SearchIO/Tiling.t ................. 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1134/1141 subtests 

[...]

Test Summary Report
-------------------
t/SearchIO/Tiling.t               (Wstat: 65280 (exited 255) Tests: 7 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 1141 tests but ran 7.
Files=211, Tests=13707, 61 wallclock secs ( 1.18 usr  0.32 sys + 53.01 cusr  6.47 csys = 60.98 CPU)
Result: FAIL
Failed 1/211 test programs. 0/13707 subtests failed.

This PR should not be merged until that is fixed.

Edit: this is now fixed by #380.

zmughal added a commit to zmughal-contrib/bioperl-live that referenced this pull request Apr 27, 2023
@zmughal
Add minimum dependency on base.pm v2.18
62c173f 
This fixes a bug in some cases when using `SUPER::new()` such as:

```
t/SearchIO/Tiling.t .................
Error: Can't locate object method "new" via package "Bio::Search::HSP::GenericHSP::SUPER"
```

Connects with <bioperl#378>.
zmughal added a commit to zmughal-contrib/bioperl-live that referenced this pull request Apr 27, 2023
@zmughal
Add minimum dependency on base.pm v2.18
b766d1b 
This fixes a bug in some cases when using `SUPER::new()` such as:

```
t/SearchIO/Tiling.t .................
Error: Can't locate object method "new" via package "Bio::Search::HSP::GenericHSP::SUPER"
```

Fixes <bioperl#307>.

Connects with <bioperl#378>.
@zmughal zmughal mentioned this pull request Apr 27, 2023
Merged
@zmughal zmughal marked this pull request as ready for review April 27, 2023 05:51
cjfields pushed a commit that referenced this pull request May 10, 2023
@zmughal @cjfields
Add minimum dependency on base.pm v2.18
b5db880 
This fixes a bug in some cases when using `SUPER::new()` such as:

```
t/SearchIO/Tiling.t .................
Error: Can't locate object method "new" via package "Bio::Search::HSP::GenericHSP::SUPER"
```

Fixes <#307>.

Connects with <#378>.
@cjfields cjfields merged commit 7adc3aa into bioperl:master May 10, 2023
@zmughal zmughal deleted the ci-perl-versions branch May 10, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmughal @cjfields