Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curated 1 mapping (sumir) #151

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Curated 1 mapping (sumir) #151

merged 3 commits into from
Aug 29, 2023

Conversation

sumirp
Copy link
Contributor

@sumirp sumirp commented Aug 28, 2023

Curated 1 predicted mapping to incorrect mapping

Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumirp this looks like a good curation! Note I made an update to include your ORCID identifier to properly give credit, so if you continue working on this branch you should pull from GitHub first. Are you planning on sending additional curations?

@sumirp
Copy link
Contributor Author

sumirp commented Aug 29, 2023

@cthoyt Thank you for your feedback. This is my first attempt for the mappings, so I would request you can merge this branch and from the next curation onwards I will try and add multiple commits in 1 branch.
Thank you

@cthoyt cthoyt merged commit ae60df4 into biopragmatics:master Aug 29, 2023
4 checks passed
@cthoyt
Copy link
Member

cthoyt commented Aug 29, 2023

@sumirp now that you've got a merge, you will need to reconcile your master branch with the Biopragmatics master branch before continuing forward. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@sumirp
Copy link
Contributor Author

sumirp commented Aug 29, 2023

@cthoyt. Thank you, I will sync the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants