Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add part_of for discovered families of prefixes #1232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bgyori
Copy link
Contributor

@bgyori bgyori commented Oct 25, 2024

This PR adds part_of relationships between prefixes and their assumed parents where missing. The PR stems from the discussion in #1222. I did the following:

  • Group prefixes by their root (e.g., aop for aop.events, aop.stressor, etc.) into families. Spot checking these relations show that these appear to be genuine families of prefixes, though there could be exceptions.
  • Check which elements of a family already have a part_of relationship to the root
  • Under the condition that a member doesn't have a part_of relationship to a root and the root is also a Bioregistry prefix, add a part_of relationship from the given prefix to the root prefix.

Questions to consider:

  • We could extend this to add part_of relations to parents that aren't Bioregistry entries. An example that already exists is pubchem.
  • Is the code that made these changes useful at all to be in version control? It might just be a one-off so I am not immediately adding it anywhere.
  • Are there any potential concerns where a part_of added here isn't actually correct, i.e., where two prefixes with .-s in them share a root but shouldn't actually have a part_of relationship to the same root?
  • As https://biopragmatics.github.io/bioregistry/datamodel/#part-of points out, there are family relationships other than the ones following the . separation pattern which aren't picked up here - these might require manual curation.

@bgyori bgyori changed the title Add part_of for discovered families Add part_of for discovered families of prefixes Oct 25, 2024
@bgyori
Copy link
Contributor Author

bgyori commented Oct 28, 2024

The test failure appears to have to due with a conflict between has_canonical and part_of relationships. In particular, insdc.run is annotated as has_canonical for ena.embl but when adding insdc.run-part_of- insdc, it results in insdc.run not being surfaced in the top-level of the registry anymore which is what the test appears to expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant