Enable overriding auto-generated URLs from registries #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
commented
May 21, 2023
|
|
||
| An override for a metaregistry is built-in to the record | ||
| >>> get_iri("kisao:0000057", provider="ols") | ||
| 'https://www.ebi.ac.uk/ols/ontologies/kisao/terms?iri=http://www.biomodels.net/kisao/KISAO#KISAO_0000057' |
There was a problem hiding this comment.
should be able to get base IRI from ols, however, bioportal is a completely different situation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #572
There are some overly-generic rules that help generate URIs for various registries. For example, the OLS almost only contained OBO Foundry ontologies at the start of the Bioregistry, so it was a reasonable assumption to make the provider URI for OLS possible to construct in a similar way to OBO Foundry PURLs. This isn't generally the case, so there are a few options:
This PR implements option 2 and uses KISAO as an example.