update ed25519-dalek and rand #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divarvel
force-pushed
the
update-ed25519-dalek
branch
from
a160593 to
29ffb22
Compare
|
the commit where i regenerate samples is broken since apparently token verification times out on my machine :-( |
Geal
force-pushed
the
update-ed25519-dalek
branch
from
29ffb22 to
1c976b9
Compare
|
updated to RC.2, everything good so far. Now we just need to wait for the release dalek-cryptography/ed25519-dalek#245 |
pinkforest
reviewed
Aug 15, 2023
Co-authored-by: pinkforest(she/her) <[email protected]>
divarvel
approved these changes
Aug 16, 2023
|
(imo this could be squash-merged, the intermediate steps are not useful in this context) |
|
after merging the latest changes from main that use static external keys in samples, I can now confirm that it is compatible both ways: main can validate tokens from this branch, and this branch validates tokens from main 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains breaking changes due to the
randupdate and will require being released in a major version update