Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnverifiedBiscuit.external_public_keys() now returns PublicKeys #263

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

divarvel
Copy link
Collaborator

@divarvel divarvel commented Jan 27, 2025

Same as Biscuit. This was also necessary for proper support of ECDSA keys

@divarvel divarvel force-pushed the unverified-external-public branch from 64ce626 to a3a040c Compare January 27, 2025 09:32
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #263 will not alter performance

Comparing unverified-external-public (1066bd5) with main (89ca84a)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (2f5700a) to head (1066bd5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   67.69%   68.12%   +0.43%     
==========================================
  Files          39       39              
  Lines        7253     7254       +1     
==========================================
+ Hits         4910     4942      +32     
+ Misses       2343     2312      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divarvel divarvel merged commit c5188e1 into main Jan 27, 2025
7 checks passed
@divarvel divarvel deleted the unverified-external-public branch January 27, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants