Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ZIP files by magic number instead of file extension #115

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

timonegk
Copy link
Member

@timonegk timonegk commented Apr 15, 2019

No description provided.

@timonegk timonegk requested a review from NFiedler April 15, 2019 15:19
@NFiedler
Copy link
Member

This will not close #114, but it might improve the way in which we are detecting zip-files. I do not know whether parts of split zip files have the same magic number...

@lilioid lilioid self-requested a review August 29, 2019 09:48
Copy link
Member

@lilioid lilioid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this looks good.
We should keep in mind though that split zip archives have a different signature so this needs to be adapted once we implement spanned archives. So this does not close #114

@lilioid lilioid merged commit cfedb64 into master Aug 29, 2019
@lilioid lilioid deleted the zip_magic_number branch August 29, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants