Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload: fix call to missing peek method #123

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Upload: fix call to missing peek method #123

merged 1 commit into from
Oct 13, 2019

Conversation

timonegk
Copy link
Member

@timonegk timonegk commented Oct 12, 2019 •
edited
Loading

Appareantly peek() does not exist on django file objects. It is replaced by read() and seek(0).

This pull request closes #121.

This was referenced Oct 12, 2019
Closed
Closed
@timonegk timonegk requested review from lilioid and NFiedler October 12, 2019 11:49
NFiedler
NFiedler approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@NFiedler NFiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@timonegk timonegk merged commit ffa4b2d into master Oct 13, 2019
@timonegk timonegk deleted the fix/no_attribute_peek branch October 13, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NFiedler NFiedler NFiedler approved these changes

@lilioid lilioid Awaiting requested review from lilioid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest code upload error
2 participants
@timonegk @NFiedler