Fix 'NoneType' object has no attribute 'name' on export #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyRamone
requested changes
Oct 15, 2020
timonegk
force-pushed
the
fix/team_can_be_none
branch
from
b88eafc to
2554ff2
Compare
Flova
requested changes
Oct 15, 2020
|
What do you think about |
timonegk
force-pushed
the
fix/team_can_be_none
branch
from
2554ff2 to
cc6cfa6
Compare
|
Sounds good. I think it is clearer if the name goes like |
When a team is deleted, its image sets are kept, but the team is changed to None. When the annotations of the set are exported, the team name is accessed which results in the above mentioned error. Now, the team name will be replaced with an empty string if the team is None.
timonegk
force-pushed
the
fix/team_can_be_none
branch
from
cc6cfa6 to
392d30a
Compare
|
Okay, I chose |
SammyRamone
approved these changes
Oct 15, 2020
Flova
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a team is deleted, its image sets are kept, but the team is changed to None. When the annotations of the set are exported, the team name is accessed which results in the above mentioned error. Now, the team name will be replaced with an empty string if the team is None.
Closes #153.